Fix Trino REGEXP_REPLACE backreference syntax#837
Merged
rschu1ze merged 1 commit intoClickHouse:mainfrom May 4, 2026
Merged
Conversation
|
|
piotrrzysko
changed the title
The replacement string used `\1` instead of `$1` (Trino syntax). In Trino, `\1` is interpreted as an escape followed by the literal character `1`, so the query was producing `1` instead of the captured domain name.
piotrrzysko
force-pushed
the
fix-trino-regexp_replace
branch
from
73e9b68 to
0d7b455
Compare
findepi
approved these changes
Apr 29, 2026
Contributor
Author
|
@alexey-milovidov could you please take a look at this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The replacement string used
\1instead of$1(Trino syntax). In Trino,\1is interpreted as an escape followed by the literal character1, so the query was producing1instead of the captured domain name.